Skip to content

Fix premium tier cache writes failing with context canceled #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
biast12 merged 1 commit into from
Oct 22, 2026
Merged

Fix premium tier cache writes failing with context canceled #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions premium/byguild.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ func (p *PremiumLookupClient) GetTierByGuild(ctx context.Context, guild guild.Gu
_src = ""

defer func() {
// cache result
if _err == nil {
// a query cut short by ctx returns no rows and no error
if _err == nil && ctx.Err() == nil {
go func() {
err := p.SetCachedTier(ctx, guild.Id, CachedTier{
err := p.cacheTier(guild.Id, CachedTier{
Tier: int8(_tier),
Source: _src,
})
Expand Down
6 changes: 3 additions & 3 deletions premium/byuser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ func (p *PremiumLookupClient) GetTierByUserWithSource(ctx context.Context, userI
}

defer func() {
// cache result
if _err == nil {
go p.SetCachedTier(ctx, userId, CachedTier{
// a query cut short by ctx returns no rows and no error
if _err == nil && ctx.Err() == nil {
go p.cacheTier(userId, CachedTier{
Tier: int8(_tier),
Source: _src,
})
Expand Down
8 changes: 8 additions & 0 deletions premium/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ type CachedTier struct {
}

const timeout = time.Minute * 5
const cacheWriteTimeout = 3 * time.Second

// Functions can take a user ID or guild ID

Expand Down Expand Up @@ -50,6 +51,13 @@ func (p *PremiumLookupClient) SetCachedTier(ctx context.Context, id uint64, data
})
}

func (p *PremiumLookupClient) cacheTier(id uint64, data CachedTier) error {
ctx, cancel := context.WithTimeout(context.Background(), cacheWriteTimeout)
defer cancel()

return p.SetCachedTier(ctx, id, data)
}

func (p *PremiumLookupClient) DeleteCachedTier(ctx context.Context, id uint64) error {
return sentry.WithSpan1(ctx, "DeleteCachedTier", func(span *sentry.Span) error {
key := fmt.Sprintf("premium:%d", id)
Expand Down
Loading