Skip to content

RM-335: Add channel flags and obfuscated channel detection - #155

Merged
biast12 merged 3 commits into
masterfrom
RM-335
Oct 8, 2026
Merged

biast12 merged 3 commits into
masterfrom
RM-335

Conversation

@biast12

@biast12 biast12 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

RM-335

Description

Supports Discord channel obfuscation.

  • Hidden channels stay in the cache so the bot can report missing View Channel instead of "not found".
  • The admin recache and the "category full" refresh now delete a cached channel only when Discord returns 404. A 403 flags the row as hidden and is remembered in Redis for 24h, so it isn't probed again.
  • The ticket-open refresh probes in the background, so it can't outlast the open lock.
  • Permission checks treat an obfuscated channel as missing View Channel, and Administrator skips that check.
  • Thread-mode open uses the interaction's permissions.
  • Claim and add admin/support re-fetch placeholder overwrites before writing them back.
  • The overflow setting is only disabled when the category is really deleted.
  • Admin debug reports "no access" and uses the guild's own bot.

Needs:
TicketsBot-cloud/gdl#17
TicketsBot-cloud/tickets.rs#17

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Preserve inaccessible channels in the cache by marking obfuscated metadata, probing unlisted channels, and tracking hidden-channel state in Redis. Update permission checks, ticket operations, admin diagnostics, and recache flows to handle missing View Channel access safely.
@biast12
biast12 requested a review from a team as a code owner September 26, 2026 18:32
@github-actions github-actions Bot added needs:gomod_comment go.mod has uncommented local replace directives type:feature New Feature labels Sep 26, 2026
@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Resolved

No blocking labels remain.

@github-actions github-actions Bot added the type:bug Bug Fixes label Sep 26, 2026
@biast12 biast12 changed the title Add channel flags and obfuscated channel detection RM-335Handle channels the bot can't view Sep 26, 2026
@biast12 biast12 changed the title RM-335Handle channels the bot can't view RM-335: Handle channels the bot can't view Sep 26, 2026
@biast12 biast12 changed the title RM-335: Handle channels the bot can't view RM-335: Add channel flags and obfuscated channel detection Sep 26, 2026
@BenHall-1

Copy link
Copy Markdown
Member

Ready for bump!

@github-actions github-actions Bot removed the needs:gomod_comment go.mod has uncommented local replace directives label Sep 27, 2026
@biast12

biast12 commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

@BenHall-1 bumped!!

BenHall-1
BenHall-1 previously approved these changes Oct 8, 2026
@biast12
biast12 merged commit a5be72a into master Oct 8, 2026
1 check passed
@biast12
biast12 deleted the RM-335 branch October 8, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug Fixes type:feature New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants