Repository navigation
Declarative tools, tool groups, read-only mode, output schemas - #5
Merged
Merged
Conversation
90 tools that send one OBS request and either print its JSON or a fixed confirmation now use registerObsRequestTool, with an optional successMessage built from the arguments. Names, titles, input schemas, and annotations are unchanged (the tool contract snapshot is identical). Read-only getters that formatted the response as prose, such as obs-get-current-scene and obs-get-input-mute, now return the OBS response as JSON so structuredContent carries the real fields. Error text is now '<Title> failed: <reason>'. 34 tools with custom behavior stay hand-written. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vjn8uBEa4mJshaQU3pFuqX
OBS_MCP_TOOLSETS (all, core, or group names), OBS_MCP_TOOLS (extra tool names), and OBS_MCP_READ_ONLY choose which tools are registered; read-only mode overrides both lists. Unset, every tool is registered as before. Unknown group or tool names stop the server at startup. The .mcpb manifest exposes the group list and read-only switch as user settings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vjn8uBEa4mJshaQU3pFuqX
registerObsRequestTool tools now declare outputSchema: the request's response
fields from docs/protocol.json, or { message } for confirmation tools, and
return matching structuredContent directly instead of re-parsing their text.
Fields are optional and nullable: live OBS 32.2.2 returns undocumented nulls
(GetSpecialInputs) and older versions omit newer fields.
A unit test calls every schema-declaring tool against protocol-shaped fake
responses; a live test calls every argument-free read-only tool against real
OBS and fails on any output validation error.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vjn8uBEa4mJshaQU3pFuqX
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4.
1. Declarative single-request tools (
1d343ac)registerObsRequestTool. The tool contract snapshot, which covers names, titles, input schemas and hints, is identical before and after.obs-get-current-scene("Current scene: X") andobs-get-input-mute, now return the OBS JSON. Error text is now<Title> failed: <reason>.2. Tool groups and read-only mode (
e36992d)OBS_MCP_TOOLSETS:all,core, or any of 14 groupsOBS_MCP_TOOLS: extra tool namesOBS_MCP_READ_ONLY: overrides both listscoreregisters 79;coreplus read-only registers 38..mcpbmanifest exposes the groups and read-only mode as user settings.3. Output schemas (
this PR's last commit)outputSchemagenerated fromdocs/protocol.json, and returnstructuredContentdirectly.GetSpecialInputsreturning undocumented nulls on OBS 32.2.2, and older OBS versions omit newer fields.Tests
core+ read-only through the built server, and refusal to start on bad names.Results:
npm run check: 71 unit, 10 e2e, manifestnpm run test:packagepassesGroups use GitHub's
github-mcp-serverpattern (--toolsets,--read-only).🤖 Generated with Claude Code
https://claude.ai/code/session_01Vjn8uBEa4mJshaQU3pFuqX