Repository navigation
Preserve PDF text origins and bound adaptive streaming - #5
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be063c62bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distinct PDF spans can share an MCID, and normalized retrieval chunks can lose their original offsets. Adaptive extraction now preserves those spans and emits hash-bound text views, source maps, reconciled span/table/cell owners, and page/region recovery assessments under schema 0.15.0.
Neutral JavaScript adapters expose rich extraction, overlap-aware chunk origins, source-range locators, prompt projections, and incremental page delivery with backpressure. Native streaming can cap serialized output and live adaptive page allocations. Interrupted, malformed, oversized, or failed streams never return an accepted completion receipt.
Independent review reproduced two additional boundary defects: missing caller source identity conflicted with chunk metadata, and malformed table rows escaped protocol classification. Both are fixed with regressions, including actual CLI readback without
--source-id. The reader retains explicit 0.14 compatibility support.Validation:
The automatic review also identified zombie-process risk from simultaneous process-group termination. Both adapters now terminate nested leaves first and let their parents reap them before group termination. Regressions assert both parent reap callbacks and actual PID disappearance; unavailable inventory or blocked reaping remains an explicit cleanup gap.
Visual completeness remains unverified. Page allocation limits exclude document caches, allocator metadata, and subprocess RSS. Paint/clipping provenance and bounded regional OCR crops are follow-up work.