Skip to content

Preserve semantic PDF text, Form geometry and bounded OCR evidence - #6

Merged
Tom-R-Main merged 4 commits into
mainfrom
codex/text-fidelity-017
Oct 10, 2026
Merged

Tom-R-Main merged 4 commits into
mainfrom
codex/text-fidelity-017

Conversation

@Tom-R-Main

@Tom-R-Main Tom-R-Main commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Adaptive reconstruction could discard ActualText replacements, omit Form text without external fallback, or damage word boundaries before creating retrieval chunks. This change preserves semantic replacement text alongside raw glyph evidence, traverses Forms with scoped resources and placement geometry, and carries writing-coordinate boundaries into public text and source locators.

Schema 0.17 also retains operator paint/clipping evidence and bounded regional OCR crop identity. Crop pixel/byte limits and region/attempt quotas preserve unresolved coverage on refusal; readers validate selected attempts, scope and document-global references. Native and adaptive text lanes now enforce the same existing quality floors.

Validation:

  • 184 JavaScript tests, without skips; native tests pass all 62 build steps.
  • Real batch/stream CLI and adapter controls cover ActualText, Unicode/PDFDocEncoding, named properties, transformed spacing, repeated Forms, cycles, paint and regional OCR.
  • All 36 corpus PDFs pass both readers; adaptive evaluation completes all 36 with local OCR. Both text lanes pass all 12 exact hard-font controls and both born-digital controls. Scanned-form, JBIG2 and JPX quality gates pass.
  • Build, shared-library and WASM gates pass. Linux/aarch64 Memcheck checker qualification, 16 parser/ABI/counter checks and six semantic controls pass without suppressions; Python/OCR memory lifetimes are outside that diagnostic run.

Paint remains operator/bbox evidence, and successful recovery does not prove visual completeness. Rotated OCR and unexplained vector-region recovery remain future qualification work. Host adoption remains separate.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T23:24:44.888843Z f739dfd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f739dfd77d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/root.zig
Comment thread src/specialist_protocol.zig
@Tom-R-Main
Tom-R-Main merged commit 9cac608 into main Oct 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant