Repository navigation
Support send to multiple topics #261
Description
FCM has introduced a way to send notification to multiple topics using the "condition" parameter in send API.
Ref: https://firebase.google.com/docs/cloud-messaging/http-server-ref
Activity
eladnava commentedon Jul 19, 2016
@vibgy Excellent PR!
However, could it be better to introduce a brand new recipient key
conditioninstead of piggybacking on thetopicparameter? @hypesystemvibgy commentedon Jul 19, 2016
@eladnava Thank you.
Let me know.. I was also debating if I should introduce "condition" or not. If you guys want me to change it, I'm happy to do so. But today is a busy day for me. I can do it tomorrow.
hypesystem commentedon Jul 20, 2016
Cool that this has been introduced! I think we should use the "condition" parameter.
This might complicate the interface for v1 or force us to rethink some things. (See and discuss at #238)
hypesystem commentedon Jul 20, 2016
I should clarify: let's use "condition" as it is closer to the underlyibg interface :)
Don't forget to add yourself as contributor in the package :)
vibgy commentedon Jul 20, 2016
Sure.. I'll update the PR. Thank you @hypesystem !
vibgy commentedon Jul 20, 2016
I updated the PR. Please review. Thanks you @hypesystem @eladnava ..
eladnava commentedon Oct 3, 2016
PR has been merged. Thanks for your hard work!