Repository navigation
Comments and the README no longer say the kernel writes the log through toyos-fat32 or tell a deleted syscall's history - #1224
Conversation
Review of #1224 at
|
…gh toyos-fat32 or tell a deleted syscall's history Comments and README text only; no code changes. The kernel's dependency on `toyos-fat32` went with its USB storage path (13ed7b4): `git grep -i fat32 -- kernel` finds nothing. Two comments still named the kernel as the crate's user, `build/fatformat.rs`'s module doc and `populate`'s doc in `build/image.rs`. The third the record listed, `lib/fat32/Cargo.toml`'s header, had already been corrected. Root README.md said the running kernel appends its log through its own FAT32 write path and writes a log file per boot; logkeeper does (system/logkeeper, `store`), through the file server. Three test binaries' module docs told what a syscall the ABI no longer declares used to do: `SYS_LISTEN` in abuse_connect_flood, `SYS_PIPE_OPEN` and `SYS_SOCKET_CREATE` in abuse_pipe_owner, `SYS_RELEASE_SHARED` in shm_release_reclaims. Each now says only what is true of its test. The fourth the record listed, the doc of `Pipe::backing` in kernel/src/pipe.rs, is gone with that function. `git grep -w -E 'SYS_WAITPID|SYS_CONNECT| SYS_AUDIO_SUBMIT|SYS_PIPE_OPEN|SYS_SOCKET_CREATE|SYS_LISTEN| SYS_RELEASE_SHARED' -- kernel system tests` finds nothing. abuse_connect_flood's opening history (the queue with no depth, the eager 2 MiB rings) is cut to the contract its assertions hold: a connect past the depth is `ResourceExhausted`, a full queue costs under a quarter of what eager rings would, and the first byte on a live connection takes a frame. shm_release_reclaims also said a region's life is its handle count and the zero-handle hook unmaps it. Neither holds: a mapping holds the object (kernel/src/object/shm.rs), `on_zero_handles` revokes only an aperture, and the SDK unmaps in `SharedMemory::drop`. It now says a region's frames go back once its last handle and last mapping have gone. Closes issues/three-comments-say-the-kernel-uses-toyos-fat32.md and issues/comments-still-name-syscalls-the-abi-deleted.md, which are deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7a8f320 to
42ffcad
Compare
|
Orchestrator verification at 42ffcad, after review r1's SEND BACK (comment-only blockers). The diff against main changes no code token: every changed Rust line is a comment (checked by filtering the diff), the rest is |
Two records named comments that say something false: that the kernel uses
toyos-fat32, and what syscalls the ABI no longer declares used to do. This corrects the comments, corrects the same false claim in rootREADME.md, and deletes both records. Comments and README text only; no code changes.three-comments-say-the-kernel-uses-toyos-fat32build/fatformat.rsmodule doc,populate's doc inbuild/image.rs); record deletedgit grep -i fat32 -- kernelfinds nothing. The third comment,lib/fat32/Cargo.toml's header, was already corrected onmaincomments-still-name-syscalls-the-abi-deletedabuse_connect_flood.rs,abuse_pipe_owner.rs,shm_release_reclaims.rs); record deleted.shm_release_reclaims.rs's remaining claim about handle count was false too and is correctedgit grep -w -E 'SYS_WAITPID|SYS_CONNECT|SYS_AUDIO_SUBMIT|SYS_PIPE_OPEN|SYS_SOCKET_CREATE|SYS_LISTEN|SYS_RELEASE_SHARED' -- kernel system testsfinds nothing. The fourth comment, onPipe::backing, is gone with that function. A mapping holds the region (kernel/src/object/shm.rsheader),on_zero_handlesrevokes only an aperture, andSharedMemory::dropunmaps before its handle closes, so the doc now says a region's frames go back once its last handle and last mapping have goneRecords: 752 on
mainat34cb4c918, 750 on this branch.Decisions a reviewer may want to question
abuse_pipe_owner.rsloses more than the syscall names. Its second and third paragraphs described the test by contrast with the sweep it replaced ("the property that replaced it", "the sweep cannot survive the fail-fast flip"). Without the first paragraph those have no referent, so they are rewritten to state the property and why each attack is a child of its own.abuse_connect_flood.rs's opening history is cut too (the queue that had no depth, the eager 2 MiB rings), to the contract its assertions hold: a connect past the depth isResourceExhausted, a full queue costs under a quarter of eager rings, and the first byte on a live connection takes a frame.README.mdis corrected here rather than recorded. Lines 199-201 said the running kernel appends its log through its own FAT32 write path, and lines 305-306 that the kernel writes a log file per boot. logkeeper writes it (system/logkeeper/src/store.rs, through the file server). It is the same false claim the first record names.Checks
cargo clippy -p toyos-build --all-targets -- $ADOPTED -D warnings(the$ADOPTEDlints ofbuild/clippy.rs) at42ffcadab: exit 0 (development host).toyos-buildis the only touched package host clippy lints:tests/guest/rust-testsis outside the host workspace and has no clippy shape, and README andissues/are not code. The merge queue runs the full host checks.cargo run -- --ci host lintat7a8f3202b: exit 0. Thebuild/comments are unchanged since. Two later full runs ended red on the development host, not on this change: no space left on device, then a missing temporary directory under the kernel's aarch64 shape, a package this branch does not touch. The run above supersedes them.mainatb56693152, which holds issues: sixteen records whose defect, code or test is gone are deleted #1220, issues: two duplicate pairs merged, and two records renamed for the test each still owes #1221 and issues: records name the programs and files the tree has #1222 (git merge-tree), and the merged tree cites neither deleted slug.🤖 Generated with Claude Code