Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 7 additions & 10 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,27 @@
[workspace]
members = [
"bcachefs",
"kernel/dma",
"kernel/gicv3",
"kernel/loom",
"kernel/pci",
"kernel/ps2",
"kernel/sim",
"tests/libc-arch",
"toyos-abi",
"toyos-acpi",
"toyos-blackbox",
"toyos-blockhold",
"toyos-blockring",
"toyos-blockring/transport",
"toyos-bootmap",
"toyos-cpuvuln",
"toyos-desktop",
"toyos-dhcp",
"toyos-dns",
"toyos-dma",
"toyos-elf",
"toyos-elide",
"toyos-fat32",
"toyos-fat32/check",
"toyos-gicv3",
"toyos-gpt",
"toyos-hda",
"toyos-i219",
Expand All @@ -43,24 +45,19 @@ members = [
"toyos-ld",
"toyos-logstream",
"toyos-manifest",
"toyos-mdns",
"toyos-microcode",
"toyos-mixer",
"toyos-net-ip",
"toyos-net-shard",
"toyos-net-tcp",
"toyos-net-testnet",
"toyos-net-shard/tcp",
"toyos-net-shard/testnet",
"toyos-net-udp",
"toyos-net-wire",
"toyos-pci",
"toyos-ps2",
"toyos-quiesce",
"toyos-rootimage",
"toyos-swap",
"toyos-symbols",
"toyos-tco",
"toyos-tmpdir",
"toyos-transport",
"toyos-untrusted",
"toyos-update",
"toyos-userbound",
Expand Down
2 changes: 1 addition & 1 deletion issues/audio/desktop-session-put-26ms-of-silence.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ soundd: wakes=389 completions=690 submitted=690 underruns=1 drains=2 max_wake_la
```

Nine periods — 26 ms — submitted with a client streaming and no client audio
behind them (`MixStats::period` in `toyos-mixer/src/stats.rs`, which is where
behind them (`MixStats::period` in `userland/soundserver/mixer/src/stats.rs`, which is where
that counter moved when the mixer's decisions became a pure crate).
There is no capture to corroborate it: `--dump-audio` was not on.

Expand Down
2 changes: 1 addition & 1 deletion issues/audio/hda-ring-fix-unverified-on-metal.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ QEMU's `intel-hda` and the T14's controller are different devices, and the fix
was measured on the first. What the next metal boot must show: `tone` playing to
completion with soundd alive, `deferred=0`, and `underruns` nonzero only if the
client stalls. Read `starve_max` on the same stats line
(`toyos-mixer/src/stats.rs`, printed by `userland/soundd/src/mix.rs`) beside
(`userland/soundserver/mixer/src/stats.rs`, printed by `userland/soundd/src/mix.rs`) beside
`underruns`: it is the longest unbroken run of underrun periods, so near 1 with
a large `underruns` is a client missing by a hair and 8–20 is a stall of one
whole 21–53 ms ring.
Expand Down
42 changes: 0 additions & 42 deletions issues/build/code-used-by-one-program-lives-in-that-program.md

This file was deleted.

8 changes: 5 additions & 3 deletions issues/build/userland-programs-are-never-linted.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ opened: 2026-09-29

# No userland program is linted, though the gated ones build for the host

`src/clippy.rs` lints no userland crate because the `toyos` toolchain ships no
clippy. The crates `src/userlandhost.rs` gates already build for the host with
the stable toolchain, and stable's clippy lints them there. They are not clean:
`src/clippy.rs` lints each crate nested under a userland program that
`src/userlandhost.rs`'s survey gates, against the host, and no userland program.
The `toyos` toolchain ships no clippy, but the programs the survey gates already
build for the host with the stable toolchain, and stable's clippy lints them
there. They are not clean:
`cargo clippy --manifest-path userland/<crate>/Cargo.toml --target
aarch64-apple-darwin --all-targets -- -D warnings` exits 101 with 8 findings
in soundd and 10 in netd. The compositor stops on 1 finding in its dependency
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ opened: 2026-10-02

# A TCP connection that takes a freed slot is queued twice

`Tcp::free` (`toyos-net-tcp/src/stack.rs`) takes a freed connection's index out of `parked` and leaves it in `active`. `transmit` drops a stale index when it pops it and finds the slot empty, but a connection that takes the slot before then is queued by `settle` under the same index, so `active` holds it twice and it has two turns a round. A copy goes when its turn finds nothing due, and the next `settle` queues another while the first is still there, so the second turn lasts for as long as the connection stays busy.
`Tcp::free` (`toyos-net-shard/tcp/src/stack.rs`) takes a freed connection's index out of `parked` and leaves it in `active`. `transmit` drops a stale index when it pops it and finds the slot empty, but a connection that takes the slot before then is queued by `settle` under the same index, so `active` holds it twice and it has two turns a round. A copy goes when its turn finds nothing due, and the next `settle` queues another while the first is still there, so the second turn lasts for as long as the connection stays busy.

Measured on `toyos-net-tcp`'s own harness (`tests/egress.rs`, `with_second`), with a scratch test that is not committed:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ opened: 2026-09-27

A consumer stores its head `Release` after it has loaded the entries below it,
and a producer loads the head `Acquire` before it writes over them
(`toyos-transport/src/queue.rs`, `Consumer::release` and `Producer::space`).
(`toyos-blockring/transport/src/queue.rs`, `Consumer::release` and `Producer::space`).
No test reds if either is `Relaxed`: what the pair forbids is load buffering —
a consumer's load of an entry reading the producer's later overwrite — which
loom does not model, and every other test runs both ends on one thread. The
Expand Down
6 changes: 4 additions & 2 deletions issues/design-debt/what-is-owed-on-file-size.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@ what survives it is a different question.

- `elf.rs` → `toyos-elf/` (host-tested, crafted-input corpus), `e2c6a06`; the
mapping half stayed as `kernel/src/elf/`, `42b29c9`.
- `compositor/main.rs` → `toyos-desktop/` (pure), `763712b`; the effects shell
- `compositor/main.rs` → `toyos-desktop/` (pure, since moved to
`userland/compositor/desktop/`), `763712b`; the effects shell
is `userland/compositor/` over five files with a 71-line `main.rs`, `72705d9`.
- `xhci/mod.rs` → the port machine is `toyos-xhci/`, with a host simulator,
`2e81ae8`.
- `soundd/main.rs` → `toyos-mixer/` (pure, `no_std`), 2026-08-20; the effects
- `soundd/main.rs` → `toyos-mixer/` (pure, `no_std`; since moved to
`userland/soundserver/mixer/`), 2026-08-20; the effects
shell is `userland/soundd/` over eight files with a 261-line `main.rs`, from a
2,366-line one. What the note asked for is what it got: **the mixing is
sample-exact and proven so.** `toyos-mixer/fixtures/mix-corpus.txt` was
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ What is open:

- **One byte reached the kernel and produced no event, and the counters could
not say which byte.** That is the open item, and half of it is the
instrument. Enumerated against the real tables (`toyos-ps2/src/key.rs`),
instrument. Enumerated against the real tables (`kernel/ps2/src/key.rs`),
**84 of the 256 single byte values decode to nothing** under set 1: both
prefixes (`0xE0`, `0xE1`), the two `Lost` codes, and every unmapped slot —
`0x54`, `0x55`, `0x59`–`0x80` and their break forms. `handle_key` drops a
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ opened: 2026-09-25
# A residue slot is held for the boot by a function never claimed again

`pcidev::release` keeps a function it could not reset in its slot as
`Slot::Residue` (`toyos-pci/src/slot.rs`), with the device addresses its last
`Slot::Residue` (`kernel/pci/src/slot.rs`), with the device addresses its last
holder's grants were at, so only that function's next claim is given the slot
and its grants are placed at those addresses. Nothing ends that hold except
that function's next claim. A function released without a reset and never
Expand Down
8 changes: 4 additions & 4 deletions kernel/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -491,19 +491,19 @@ toyos-abi = { path = "../toyos-abi" }
[target.'cfg(target_os = "none")'.dependencies]
bcachefs = { path = "../bcachefs", default-features = false }
toyos-acpi = { path = "../toyos-acpi" }
toyos-dma = { path = "../toyos-dma" }
toyos-dma = { path = "dma" }
toyos-elide = { path = "../toyos-elide" }
toyos-blackbox = { path = "../toyos-blackbox" }
toyos-blockhold = { path = "../toyos-blockhold" }
toyos-bootmap = { path = "../toyos-bootmap" }
toyos-fat32 = { path = "../toyos-fat32" }
toyos-elf = { path = "../toyos-elf" }
toyos-gicv3 = { path = "../toyos-gicv3" }
toyos-gicv3 = { path = "gicv3" }
toyos-gpt = { path = "../toyos-gpt" }
toyos-hda = { path = "../toyos-hda" }
toyos-pci = { path = "../toyos-pci" }
toyos-pci = { path = "pci" }
toyos-tco = { path = "../toyos-tco" }
toyos-ps2 = { path = "../toyos-ps2" }
toyos-ps2 = { path = "ps2" }
toyos-rootimage = { path = "../toyos-rootimage" }
toyos-quiesce = { path = "../toyos-quiesce" }
toyos-symbols = { path = "../toyos-symbols" }
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion toyos-pci/Cargo.toml → kernel/pci/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ license = "MIT OR Apache-2.0"
# The window type the bootloader hands the kernel, declared once in the ABI and
# read here rather than mirrored: a second spelling of a base and a length is
# two readers that can disagree about one machine's aperture.
toyos-abi = { path = "../toyos-abi" }
toyos-abi = { path = "../../toyos-abi" }
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion src/ci.rs
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ fn host(root: &Path) -> Vec<Step> {
Ok("installed".into())
}));
steps.push(step("clippy, warnings denied", || {
let failed = crate::clippy::run(root);
let (failed, _) = crate::clippy::run(root)?;
if failed.is_empty() {
Ok("clean".into())
} else {
Expand Down
Loading
Loading