Skip to content

chore: sync with upstream pingdotgg/t3code main - #228

Merged
yordis merged 4 commits into
mainfrom
yordis/chore-sync-upstream-20261112-2
Nov 12, 2026
Merged

yordis merged 4 commits into
mainfrom
yordis/chore-sync-upstream-20261112-2

Conversation

@yordis

@yordis yordis commented Nov 12, 2026 •

Copy link
Copy Markdown
Member
  • Clean merge of 3 upstream fixes (read-only preview select-all copy, update command for hand-started servers, faster large recording saves); no fork divergence touched, no conflicts, ledger unchanged.

Note

Medium Risk
Touches install/update detection, server startup env handling, and recording persistence paths; mistakes could mis-identify installs or lose/corrupt large recordings, but changes are covered by new tests.

Overview
Adds t3-launcher as a first-class server install type so hand-started / symlinked pinned runtimes are detected, advertised to the client, and get a proper t3 update --base-dir … manual update command (UI copy-to-clipboard and docs included). resolveLauncherPath moves to pinnedRuntime, resolves PATH like a shell (skips non-executables), and is used earlier at server boot so InvokedAs survives fixPath.

Large tab recordings (≥8 MiB) stop pulling Base64 chunks over CDP and instead trigger a browser download into a staged file, with integrity checks and tests.

Read-only file preview intercepts copy when Select All spans the virtualized diff view so the full file text lands on the clipboard, with a browser test.

Reviewed by Cursor Bugbot for commit c97c1e9. Bugbot is set up for automated code reviews on this repo. Configure here.

Yuruzuu and others added 4 commits November 12, 2026 13:14
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…them (pingdotgg#29462)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
… whole file (pingdotgg#33903)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
@yordis
yordis merged commit 3637543 into main Nov 12, 2026
15 of 18 checks passed
@yordis
yordis deleted the yordis/chore-sync-upstream-20261112-2 branch November 12, 2026 21:47
@github-actions

Copy link
Copy Markdown

This PR changes the test suite by +3 test cases (browser +1, unit 0, server +2).

New browser test files: apps/web/src/components/files/ReadOnlySourcePreview.browser.test.tsx.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

@github-actions github-actions Bot added the vouch:trusted Author is trusted by repo permissions or the VOUCHED list. label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants