Repository navigation
Replaced NQL Lerna tooling with Nx - #279
Merged
Merged
Conversation
ref https://linear.app/ghost/issue/PLA-322 Refresh the migration against current main and preserve the better-sqlite3 test matrix and privileged publish install safeguards.
ref #201 Checked the wrapper and native tarballs against the committed integrity pins without running bootstrap lifecycle scripts in the OIDC job. Corrected pnpm setup instructions.
ref #201 Follow the framework Nx task and independent-release pattern. Preserve names, versions, tag format and literal 0.x bump semantics. Keep secured OIDC publishing restricted to missing versions, and include database settings in test cache inputs so MySQL cannot replay SQLite results.
|
Warning Review limit reached
This review includes 8 billable files and costs up to $2.00. Or wait 52 minutes for your next included review. View limit details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 85.52% 85.52%
=======================================
Files 9 9
Lines 2293 2293
Branches 484 484
=======================================
Hits 1961 1961
Misses 326 326
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ref #279 Resolve the ancestry conflicts after the pnpm prerequisite was squash-merged. Retain the validated Nx implementation and the latest action pins from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NQL currently uses Lerna for task orchestration and independent versioning. This adopts framework's Nx pattern and the same setup as SDK's follow-up: Nx orders parser builds before dependent tests,
pnpm shipversions and pushes, and the existing OIDC workflow publishes only versions missing from npm.Follows the pnpm/security rollout merged in #201 and targets current main.
pnpm ship; documents versioning and publishing dry-runs.Validation: frozen scripts-disabled install; lint/build and all four test suites with SQLite and isolated MySQL 8 (container removed); all four package publish dry-runs; nql-lang minor/major previews update nql and its range correctly; package manifests unchanged after previews; wrong-branch ship guard; live registry selection skipped all four published versions. Selection is identical to SDK's validated implementation, including missing/private packages and registry 401/429/500 failures. actionlint and git diff checks passed. No packages published or release tags pushed.