-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add desktop subscription group management #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kapdon
wants to merge
31
commits into
TypeType-Video:dev
Choose a base branch
from
kapdon:codex/subscription-groups-ux
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
bbd1ef2
feat: add subscription group models and selection helpers
kapdon 99e7231
feat: add subscription group API client and batch writes
kapdon 88f9fe3
feat: translate subscription group management messages
kapdon 5493f96
feat: load group memberships and refresh subscription caches
kapdon 658cc63
feat: add group forms and destructive action confirmations
kapdon f55c78f
feat: add subscription group sidebar and group actions
kapdon b2c1387
feat: add searchable inline group membership editing
kapdon 7147e69
feat: manage channel selection and group edit drafts
kapdon 4967629
feat: show group editors for single selected channel rows
kapdon 46edab7
feat: add group membership filters and bulk action toolbar
kapdon 358224f
feat: assemble the subscription group management page
kapdon 6696598
feat: integrate group filters into subscription views
kapdon 8683521
docs: describe subscription group UX and verification
kapdon 4b2e732
fix: preserve subscription feed after pagination errors
kapdon 9cc1cf7
test: add varied subscription group fixture data
kapdon 06bf5ce
test: serve a reproducible subscription group preview
kapdon 0b4dd9a
feat: add viewport-aware subscription group pagination
web-flow c170675
style: compact group management with TypeType controls
web-flow 51a40c3
fix: pause group editing after failed data refreshes
web-flow e43274c
test: cover group refresh recovery and document verification
web-flow 93ebe61
docs: record TypeType's upstream design conventions
web-flow 23386da
refactor: share subscription queries and cache refreshes
web-flow 8de58af
fix: cancel subscription reads and preserve API errors
web-flow 991c863
fix: bound membership writes and target query refreshes
web-flow 3656733
fix: recover subscription filters and empty states
web-flow 855e7a2
fix: add accessible group action menus
web-flow 2ae956b
docs: narrow group management scope after review
web-flow f14b697
feat: query server pages and bounded membership selections
web-flow 681c587
feat: retain channel selection across server-paginated results
web-flow ae115de
test: serve paginated subscription membership fixtures
web-flow d1716f5
chore: remove group management planning documents
web-flow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed flow in TypeType #172 was to help organize newly imported channels, not just open the full manager. Is that intentionally deferred? If so, state that explicitly in the PR scope and acceptance criteria; otherwise this integration is incomplete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, organizing only newly imported channels is intentionally deferred. I have made that explicit in the PR’s scope and acceptance criteria: the current post-import link opens the full manager and does not select or filter an imported cohort. This PR is now described as a partial implementation of #172 and does not close it.