test(project): Reproduce abort/retry delta over-write - #1627
Merged
Merged
Conversation
Add a minimal reproduction of the build-server abort/retry over-write. A
delta rebuild only re-processes the files that actually changed. When
such a rebuild is aborted mid-flight and restarted, the retry
re-processes ALL files the task handles instead of just the changed one.
The served output stays correct (the retry writes the same bytes), so
this is an optimization gap — redundant writes of unchanged files —
rather than a correctness fault.
The replaceCopyright task substitutes ${copyright} in every file that
contains it; the library.d fixture has two such files (some.js and
.library). The test runs three builds:
1. Build once so the caches are warm.
2. A clean delta rebuild that changes only some.js. replaceCopyright
writes only some.js. This already passes today.
3. The same delta, but aborted mid-build and retried. The retry should
again write only some.js, but today it also re-writes .library.
Steps 2 and 3 use the same skipped-task set and expect the same written
delta, so the aborted build differs from the clean one only in the
replaceCopyright written set. That isolates the abort as the sole cause
of the over-write. Both are asserted via the FixtureTester
writtenResources assertion.
To drive the mid-build abort, requestResource gains an onBuildStatus
hook that is attached for the duration of the request, so tests no
longer hand-roll the process.on/off dance around byPath. _assertBuild
dedupes the skipped-task list because an abort+retry emits one task-skip
event per attempt.
Marked test.serial.failing until the abort/retry delta is optimized to
re-process only the changed file.
JIRA: CPOUI5FOUNDATION-1363
RandomByte
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a minimal reproduction of the build-server abort/retry over-write. A delta rebuild only re-processes the files that actually changed. When such a rebuild is aborted mid-flight and restarted, the retry re-processes ALL files the task handles instead of just the changed one. The served output stays correct (the retry writes the same bytes), so this is an optimization gap — redundant writes of unchanged files — rather than a correctness fault.
The replaceCopyright task substitutes ${copyright} in every file that contains it; the library.d fixture has two such files (some.js and .library). The test runs three builds:
Steps 2 and 3 use the same skipped-task set and expect the same written delta, so the aborted build differs from the clean one only in the replaceCopyright written set. That isolates the abort as the sole cause of the over-write. Both are asserted via the FixtureTester writtenResources assertion.
To drive the mid-build abort, requestResource gains an onBuildStatus hook that is attached for the duration of the request, so tests no longer hand-roll the process.on/off dance around byPath. _assertBuild dedupes the skipped-task list because an abort+retry emits one task-skip event per attempt.
Marked test.serial.failing until the abort/retry delta is optimized to re-process only the changed file.
JIRA: CPOUI5FOUNDATION-1363