fix(framework): use hasOwnProperty for asyncFinished guard to prevent inherited value from skipping define() await - #14087
Merged
Merged
Conversation
… inherited value from skipping define() await
nnaydenow
requested review from
pskelin and
vladitasev
and removed request for
vladitasev
September 24, 2026 08:34
|
🚀 Deployed on https://pr-14087--ui5-webcomponents-preview.netlify.app |
vladitasev
approved these changes
Sep 24, 2026
vladitasev
left a comment
vladitasev
left a comment
Contributor
There was a problem hiding this comment.
The fix is correct and minimal. Object.prototype.hasOwnProperty.call(ctor, "asyncFinished") properly scopes the check to each class's own property, preventing a subclass with i18n bundles from inheriting the parent's asyncFinished = true flag and skipping its own _definePromise await. Both call sites updated consistently. The one CI failure (Tokenizer "tests token removal") is a pre-existing flaky test unrelated to this change — re-triggered and passing on rerun.
|
🧹 Preview deployment cleaned up: https://pr-14087--ui5-webcomponents.netlify.app |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A subclass with i18n bundles extending a parent without i18n bundles would incorrectly skip awaiting its own
_definePromisein connectedCallback. The parent'sdefine()finishes first and setsasyncFinished = trueas an own property; the child's prototype chain lookup finds that value and bypasses the await, causing render to fire before the child's i18n bundle is loaded.Use
Object.prototype.hasOwnProperty.call(ctor, "asyncFinished")in bothconnectedCallbackand thedefinePromisegetter so each class only considers its own asyncFinished flag.