Skip to content

Improvements to RequisiteParser (Packrat Parsing) #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Yogeb-tech wants to merge 11 commits into
base: develop
Choose a base branch
from
+440 −795
Draft

Improvements to RequisiteParser (Packrat Parsing) #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7bcf922
imports
Yogeb-tech Apr 8, 2026
6635877
3 prototype matchers + basic testing
Yogeb-tech Apr 9, 2026
29a9940
DRY, the code looks much better now
Yogeb-tech Apr 10, 2026
72ab6f0
implemented most matchers. Currently AND, OR, and possibly Group Matc…
Yogeb-tech Apr 11, 2026
d408bc7
and & or matchers are replicated. working on parenthesis next
Yogeb-tech Apr 11, 2026
00da09c
AND and OR matchers work, working on parenthesis
Yogeb-tech Apr 12, 2026
64cfc04
Parenthesis work, I can fully replace parser now hopefully
Yogeb-tech Apr 14, 2026
ddc45e6
parsing works
Yogeb-tech Apr 17, 2026
bc3bf93
polish: comments and rearranging code
Yogeb-tech Apr 17, 2026
5e77c13
Merge branch 'develop' into packrat-requisite-parser
Yogeb-tech Apr 17, 2026
b1c0cdd
Merge branch 'develop' into packrat-requisite-parser
Yogeb-tech Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ require (
github.com/UTDNebula/nebula-api/api v0.0.0-20260525053158-3209b0868dcf
github.com/chromedp/cdproto v0.0.0-20260321001828-e3e3800016bc
github.com/chromedp/chromedp v0.15.1
github.com/cphaensch/go-packrat/v2 v2.1.1
github.com/dongri/phonenumber v0.1.12
github.com/getsentry/sentry-go v0.46.2
github.com/google/go-cmp v0.7.0
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ github.com/chromedp/sysutil v1.1.0 h1:PUFNv5EcprjqXZD9nJb9b/c9ibAbxiYo4exNWZyipw
github.com/chromedp/sysutil v1.1.0/go.mod h1:WiThHUdltqCNKGc4gaU50XgYjwjYIhKWoHGPTUfWTJ8=
github.com/cncf/xds/go v0.0.0-20260202195803-dba9d589def2 h1:aBangftG7EVZoUb69Os8IaYg++6uMOdKK83QtkkvJik=
github.com/cncf/xds/go v0.0.0-20260202195803-dba9d589def2/go.mod h1:qwXFYgsP6T7XnJtbKlf1HP8AjxZZyzxMmc+Lq5GjlU4=
github.com/cphaensch/go-packrat/v2 v2.1.1 h1:93C9KEwQJ4yGNx0VDIyXG7kqf534+77cihCqIBXQdDs=
github.com/cphaensch/go-packrat/v2 v2.1.1/go.mod h1:kFr8iPj4Am06hrzkVm4KK21H6uDQG5KAT5SI0mLpQQo=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/dongri/phonenumber v0.1.12 h1:rR/4VZzxqpocUdyM4dIdfY0TWd8FcW43oiyPaOUxNIk=
Expand Down
3 changes: 0 additions & 3 deletions parser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ func Parse(inDir string, outDir string, csvPath string, skipValidation bool) {

log.Print("\nParsing course requisites...")

// Initialize matchers at runtime for requisite parsing; this is necessary to avoid circular reference errors with compile-time initialization
initMatchers()

for _, course := range Courses {
ReqParsers[course.Id]()
}
Expand Down
Loading
Loading