Repository navigation
Added lint-check.yml to fail pr when user does not run make check before making a pr - #207
Open
ariana-r-chowdhury wants to merge 2 commits into
Open
ariana-r-chowdhury wants to merge 2 commits into
ariana-r-chowdhury wants to merge 2 commits into
Conversation
Contributor
|
Woah! This is great! I'm checking it out rn |
justinschwerdtfeger
requested changes
Oct 14, 2026
justinschwerdtfeger
left a comment
Contributor
There was a problem hiding this comment.
This is great!
git diff is a great way to check for changes!
Small tweak:
Lets copy this over to our existing go.yml instead of running a new github action
Author
|
Thanks! I will do that by this afternoon and submit another pr. |
Contributor
|
You just need to push update commit. Pr will auto-update :) |
Author
|
I added the "Fail if files changed" step ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #183
I modeled this following UTD Trends' lint check. The workflow runs when a pull
request is made to develop (and on pushes to develop, or manually). It
runs on ubuntu-latest with these steps:
make setupto install staticcheck and goimportsmake checkgit diff --exit-code. Ifmake checkhadto change any file, the check fails.
I had never worked with GitHub workflows before, so this was a big learning step. I used GitHub's "Creating an example workflow" docs to understand how a workflow operates, as well as checked out the api-tools workflow to better understand what is needed to solve this issue.