Repository navigation
Conversation
|
|
Member
|
Thank you for your contribution! Once you've marked this PR as ready for review I can merge it in (or review any additional changes you make between now and then). |
uqzcolbe
marked this pull request as ready for review
October 15, 2026 23:07
Author
|
Thanks, should be ready now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NcML documents stored in S3 can reference datasets through absolute HTTP, HTTPS or DAP URLs. When the document location uses cdms3, URLnaming incorrectly appends these URLs to the object prefix, causing dataset reads to fail. Preserve absolute references in both wrapper and aggregation resolution while retaining relative object-name handling.
Add regression tests for reference resolution and HTTP dataset reads through NcML wrappers and aggregations. The tests use generated data and a loopback HTTP server without cloud credentials or external datasets.