Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#449 (PyO3 engine) | Unleash/yggdrasil-bindings#171 (release the GIL while loading state)
Why the change
Every poll that brings nothing new — a 304, or a failed fetch — reloads the cached state into the engine, so the SDK parses the same payload again every refresh interval, and with the PyO3 engine that parse also blocks every other Python thread in the process while it runs.
Special things to note
Change outline
What a skipped reload saves, per poll, on a real 0.67 MB production payload with 257 toggles (macOS arm64, Python 3.12):
Tests cover the four cases: an unchanged body is not reloaded, a body another process cached is loaded, a body that failed to load is retried, and a streamed update forces the next load.
make lint, the unit tests and the client specification tests pass.