Skip to content

refactor: remove environment setting - #461

Merged
alexanto merged 1 commit into
mainfrom
refactor/remove-environment-option
Oct 29, 2026
Merged

alexanto merged 1 commit into
mainfrom
refactor/remove-environment-option

Conversation

@alexanto

@alexanto alexanto commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes the environment setting, as as a followup of #457. The API token decides the environment both for impact metrics and context, they are always matching now. Defaults to "default" as before

breaking behavior change: environment IN [default] matched every call in v6 and won't match in v7

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ppicom ppicom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@github-project-automation github-project-automation Bot moved this from New to Approved PRs in Issues and PRs Oct 28, 2026
@alexanto
alexanto merged commit 621bf4d into main Oct 29, 2026
9 checks passed
@alexanto
alexanto deleted the refactor/remove-environment-option branch October 29, 2026 07:31
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Issues and PRs Oct 29, 2026
@Elyahou Elyahou mentioned this pull request Oct 29, 2026
8 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants