Repository navigation
refactor: move config props to where they belong - #462
Merged
Merged
Conversation
alexanto
changed the title
alexanto
changed the title
ppicom
reviewed
Oct 28, 2026
ppicom
left a comment
ppicom
left a comment
Contributor
There was a problem hiding this comment.
Nice! I'd just double check why CodeQL feels like we are going to leak secrets with that log line.
| if mode == InstanceAllowType.BLOCK: | ||
| raise MultipleInstancesNotAllowedError(msg) | ||
| if mode == InstanceAllowType.WARN: | ||
| LOGGER.error(msg) |
Contributor
There was a problem hiding this comment.
CodeQL flagged this log line as a potential leak. Can we double check it? I see that we moved redact_to_print_safely to a different location but it's still in use, so no biggie.
Contributor
Author
There was a problem hiding this comment.
i think CodeQL gives a false positive here, doesn't know that redact_to_print_safely is a sanitizer
and i checked if i just remove the @Property it already fires this warning, so i think it was the decorator that made CodeQL skip it
alexanto
force-pushed
the
refactor/remove-metrics_interval_str_millis
branch
from
October 29, 2026 07:32
4b77c61 to
4ca2468
Compare
github-project-automation
Bot
moved this from In Progress
to Approved PRs
in Issues and PRs
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opinion: with an immutable config there's no reason for these separate properties
there are only used at one place each