Skip to content

uref: duration and rate as inline members instead of dictionary attri… - #1258

Open
kierank wants to merge 1 commit into
Upipe:masterfrom
kierank:uref-inline-duration-rate
Open

kierank wants to merge 1 commit into
Upipe:masterfrom
kierank:uref-inline-duration-rate

Conversation

@kierank

@kierank kierank commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

…butes

Every framer sets the duration and reads the rate of each frame it outputs and every sink reads the duration, through the dictionary's control dispatch and a scan each time. They join the dates and delays in struct uref, with the same accessor names and error codes. The shorthand types stay in the enum so the numbering does not move. uref_dup copies them, and uref_attr_import copies them when the source has them, as it did when they were dictionary attributes (audiocont, videocont, grid and video_blank rely on it).

…butes

Every framer sets the duration and reads the rate of each frame it
outputs and every sink reads the duration, through the dictionary's
control dispatch and a scan each time.  They join the dates and delays
in struct uref, with the same accessor names and error codes.  The
shorthand types stay in the enum so the numbering does not move.
uref_dup copies them, and uref_attr_import copies them when the source
has them, as it did when they were dictionary attributes (audiocont,
videocont, grid and video_blank rely on it).
@kierank
kierank force-pushed the uref-inline-duration-rate branch from d59b66f to 442f5b8 Compare September 28, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant