Repository navigation
Dup last sub - #1259
Open
kierank wants to merge 3 commits into
Open
Dup last sub#1259kierank wants to merge 3 commits into
kierank wants to merge 3 commits into
Conversation
The loop declared a second variable named output for the current sub, so the test that the dup has no direct output read the sub pointer instead and never held: every sub got a copy and the original was freed after the loop, one uref_dup and one uref_free per input more than written. The dup test now checks which sink receives the original.
ulist is circular, so the last sub's uchain->next is the list head and never NULL: every TS packet on every PID was duplicated once per sub and the original freed afterwards. A PID with a single sub now costs no allocation in the split.
Same circular-list test as in upipe_ts_split: every section was duplicated once per sub and the original freed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.