Repository navigation
Fix incorrect error handling - #1264
Merged
Merged
Conversation
quarium
reviewed
Oct 7, 2026
quarium
reviewed
Oct 7, 2026
The previous input name was freed before duplicating the new one, but the pointer was left dangling if strdup failed, so it was used and freed again later.
The flow definition was freed once passed to setflowdef, then freed again on the error path if the rtpd inner pipe could not be allocated.
If strdup fails, input_name still points to a freed string, which is then returned by get_input and freed again on the next set_input or when the pipe is freed.
When the gallery picture buffer could not be allocated, the duplicated gallery uref was freed but the pipe kept a pointer to it, which was then used by the next picture and freed again in upipe_sws_thumbs_free.
quarium
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.