Repository navigation
Conversation
The output flow_def was built with uref_sibling_alloc(), which returns an empty uref, so every attribute of the input flow_def was dropped. Instead duplicate the input flow_def like other pipes that change the flow type do.
The UBASE_RETURN()s following the output flow_def allocation returned without freeing it. Free it on failure. Also check the result of uref_flow_set_def().
When uref_pic_plane_write() failed, the picture was freed but the loop went on: it wrote through an uninitialized pointer, then used (or freed again) the freed uref. Log an error and drop the rest of the input packet instead, as the other failure paths in the loop do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed the PID in the output flow_def so I asked Claude about about the pipe and if its set_flow_def function was the usual way a pipe should change a flow from block to pic. It said no
uref_sibling_allocwas to blame and said it should just beuref_dupand clear the old format.Secondly it pointed out a pair of bugs in the case of errors so I took those fixes too.