Repository navigation
Give the cap-eviction scenario an idle window it can cross the cap in - #2395
Merged
Merged
Conversation
The scenario opens sessions one at a time and needs cap + 1 (25) resident at once, but each session idles out MCP_SESSION_TIMEOUT_MS after it opened. At 3s, 25 opens took the whole window on a CI runner (80-125ms each). When they ran over, early sessions idled out as new ones opened, the cap was never crossed, and the scenario timed out. Raise the e2e idle timeout to 8s in CI and the e2e default, and document the constraint next to the cap.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | ce6ad38 | Oct 25 2026, 09:27 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | ce6ad38 | Commit Preview URL Branch Preview URL |
Oct 25 2026, 09:27 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
October 25, 2026 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mcp-session-cap-evictiontimes out on about onemainrun in four (4 of the last 15 CI runs).The scenario opens sessions one at a time and needs cap + 1 of them (25, with the e2e cap of 24) resident at once. Each session's runtime idles out
MCP_SESSION_TIMEOUT_MS(3s in CI) after it opened. An open costs about 80-125ms on a CI runner, so 25 opens take roughly the whole window. In the failing runs, the first idle disposal landed just as the 25th session opened, and every later open was offset by another one. The cap was never crossed, the span search came up empty, and the cleanup's restores of the now-idle sessions ran the test into its 180s timeout.The cap itself can't come down much:
mcp-protocol.test.tskeeps about a dozen sessions resident within a second or two. This raises the e2e idle timeout to 8s, in the cloud shard env and the e2e default, which gives 25 opens 2.5x headroom at CI's slow end. It also documents the constraint next to the cap constant. Scenarios that wait for idle disposal derive their waits from the configured timeout, so they still work, each about 5s slower.Test environment only; production is unchanged.