Repository navigation
Conversation
Catch reruns the common setup for each of the three sections. The CCSD, spintrace, density-fitting and CSV derivation therefore ran three times, although only the round-trip section consumes the equations. Move the derivation and its size check into that section. Keep the named-basis metadata, committed-fixture and slot-layout checks in place; the latter two sections no longer derive equations they do not use.
granted_registry({}) returns the same minimal registry without applying
any grants. Deriving CCSD with both registries repeats the same
calculation, and their equality supplies no independent expected result.
Keep one derivation and the explicit null-instance and zero-standing-
metric checks. Remove the second derivation and repeated-run comparison;
keep the separately granted acceptance check.
The test already derives raw Lambda equations to check their integral slots. derive_λ then derives those equations again before spintracing. Spintrace the existing raw equations under the same scoped registry. Keep the raw checks before tracing and retain the traced instance, family and metric checks. Keep the temporary-index reset before the initial derivation, without adding one between derivation and tracing.
The fixed mirrored configuration parsed and optimized the same residual separately for structural checks and execution. Run both stages on one optimized forest and schedule, retaining the static assertions before the strict dry-run walk. The executor still builds its own internal cell table. Move the separate schedule-shape checks into the existing partition- equivalence case, which builds the identical fixture. Retain its independent two-set reference and carry the w20-auxocc tag with the checks. Both retained cases stay behind SEQUANT_SKIP_LONG_TESTS, so these changes save work only when long tests are enabled. Combining the cases reduces separate reporting; a fatal static failure stops the execution stage. Keep the default structural fixture separate because its occupancy- scaled budget differs on master. Leave all STCC cases unchanged.
ajay-mk
force-pushed
the
ajay/test/reduce-repeated-setup
branch
from
October 24, 2026 18:57
3e3e290 to
4516951
Compare
Member
Author
|
Formatting check failure should be resolved after #733 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #727.
Reduce repeated setup while retaining the distinct checks:
Each commit message explains the changes in detail.
Water20 tests remain behind
SEQUANT_SKIP_LONG_TESTS. The default structural fixture retains its occupancy-scaled budget; the mirrored fixture keeps its fixed 25e9 budget.Preserve the water20 explanations covering schedule shapes, runtime checks, shared configuration, and local MPQC reproduction, updating outdated wording and diagnostic guidance.
The merged mirrored-water20 case runs static validation first; a fatal static failure prevents the runtime stage.