Repository navigation
More CSE handling fixes - #731
Merged
Merged
Conversation
perform_cse called batches.back() on an empty batch list when given no expressions. This happens for the persistent part of a replay-optimized input that has no persistent intermediates. Return "no change" instead, so the input is aliased through unmodified.
Replacing a whole root expression by a CSE rebuilds the root tree, which assigns it a new node ID. Dependencies recorded earlier (by the dependencies step) then refer to IDs that no longer exist, and the export step fails to find the producer. Restore the original ID on the rewritten tree.
Template steps may carry a "when" property and are only part of the expansion if its value is truthy. References marked with a trailing '?' (in inputs, inherit_options_from and the grouping, merge_inputs and relative_order options) are dropped if the step they name does not exist after expansion, and steps left without inputs are dropped along with them. This allows a single template to cover variants that differ in additional steps (e.g. a replay-optimized part), instead of defining those separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.