Conversation
「Verify every .vpx is signed」在包缓存里硬拼 tools/net11.0/VelaShell.Plugin.Cli.dll; VelaShell.PluginSdk.Build 自 2.0.5 起包里换成了 VelaShell.PluginSdk.Packer.dll, 本仓库钉的是 2.0.8,于是 2.0.4 发版在最后一道核对上失败(构建、打包、签名都已通过)。 改为向 MSBuild 求值 $(VelaPluginPacker)(由 .Build 包的 .targets 定义):核对与打包 用的是同一个打包器,包内文件名再变也不会再断。打包器的 info 输出格式与旧 CLI 一致, flags / signature 的判定不用改。顺带把两处注释里的 vela-plugin 改成打包器。 本地验证:临时 P-256 密钥签出 6 个 .vpx,原样抽出这一步的脚本运行,6 个全部判为 已签名;混入一个未签名包时如期失败(flags Masked / signature Unsigned)。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 2.0.4 发版失败(run 37141858902)。
「Verify every .vpx is signed」在包缓存里硬拼
tools/net11.0/VelaShell.Plugin.Cli.dll;VelaShell.PluginSdk.Build自 2.0.5 起包里换成了VelaShell.PluginSdk.Packer.dll,本仓库钉的是 2.0.8,于是发版在最后一道核对上失败(构建、打包、签名都已通过)。$(VelaPluginPacker)(由 .Build 包的 .targets 定义):核对与打包用的是同一个打包器,包内文件名再变也不会再断。info的输出格式与旧 CLI 一致,flags/signature的判定不用改。本地验证
用临时 P-256 密钥按发版流程签出 6 个 .vpx,原样抽出这一步的脚本运行:6 个全部判为已签名(打包器解析到
velashell.pluginsdk.build/2.0.8/tools/net11.0/VelaShell.PluginSdk.Packer.dll);混入一个未签名包时如期失败(flags Masked/signature Unsigned)。合入后在 GitHub 上重新发布 Release 2.0.4 即可(旧的那次重跑会沿用标签所在提交里的旧工作流)。不改行为、接口与配置,velashell-docs 无需同步。