Skip to content

Added get_curations() and filter_by_curation() - #125

Open
tonywu1999 wants to merge 1 commit into
develfrom
MSstatsBioNet/work/20261006_phase4c-curation
Open

tonywu1999 wants to merge 1 commit into
develfrom
MSstatsBioNet/work/20261006_phase4c-curation

Conversation

@tonywu1999

Copy link
Copy Markdown
Contributor
  • get_curations() counts the evidence curated as incorrect, one request per statement hash, at the new indra_backend(curation_url =)
  • filter_by_curation() subtracts it from evidence_count, drops edges left below min_evidence or with no evidence, and drops nodes left without edges
  • The backend comes from backend_database, as in get_evidence(); a get_curations() table with a non-character statement_id errors
  • getSubnetworkFromIndra(filter_by_curation = TRUE) now calls filter_by_curation()

Motivation and Context

Please include relevant motivation and context of the problem along with a short summary of the solution.

Changes

Please provide a detailed bullet point list of your changes.

Testing

Please describe any unit tests you added or modified to verify your changes.

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • Ran styler::style_pkg(transformers = styler::tidyverse_style(indent_by = 4))
  • Ran devtools::document()

* get_curations() counts the evidence curated as incorrect, one request per statement hash, at the new indra_backend(curation_url =)
* filter_by_curation() subtracts it from evidence_count, drops edges left below min_evidence or with no evidence, and drops nodes left without edges
* The backend comes from backend_database, as in get_evidence(); a get_curations() table with a non-character statement_id errors
* getSubnetworkFromIndra(filter_by_curation = TRUE) now calls filter_by_curation()

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 78c61ba7-369f-4adf-9c80-38a222b28cc4
📥 Commits

Reviewing files that changed from the base of the PR and between c4e6b33 and a8b9413.

📒 Files selected for processing (17)
  • NAMESPACE
  • NEWS.md
  • R/AllClasses.R
  • R/AllGenerics.R
  • R/backend-indra-db.R
  • R/backend-indra.R
  • R/backend-registry.R
  • R/getSubnetworkFromIndra.R
  • R/network-postprocess.R
  • R/utils_getSubnetworkFromIndra.R
  • man/NetworkBackend-class.Rd
  • man/filter_by_curation.Rd
  • man/getSubnetworkFromIndra.Rd
  • man/get_curations.Rd
  • man/indra_backend.Rd
  • tests/testthat/test-curation.R
  • tests/testthat/test-getSubnetworkFromIndra.R
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.05825% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.36%. Comparing base (c4e6b33) to head (a8b9413).

Files with missing lines Patch % Lines
R/backend-indra-db.R 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #125      +/-   ##
==========================================
+ Coverage   85.23%   86.36%   +1.12%     
==========================================
  Files          22       24       +2     
  Lines        2547     2618      +71     
==========================================
+ Hits         2171     2261      +90     
+ Misses        376      357      -19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants