Skip to content

Use the connection state when implicitly opening MIDIInput - #293

Closed
JinDX wants to merge 1 commit into
WebAudio:gh-pagesfrom
JinDX:patch-1
Closed

JinDX wants to merge 1 commit into
WebAudio:gh-pagesfrom
JinDX:patch-1

Conversation

@JinDX

@JinDX JinDX commented Oct 26, 2026

Copy link
Copy Markdown

Describe implicit MIDIInput opening in terms of connection and the existing "open" MIDIPortConnectionState value. MIDIPort.state describes whether the device is connected, and neither enum contains an "opened" value.

@mjwilson-google

Copy link
Copy Markdown
Member

Thank you for catching and fixing this!

I think it is covered by #288 which hasn't laded yet. Please take a look at that PR; if there is something missing we can use this PR to fix it otherwise I would prefer to fix it with #288.

@JinDX JinDX closed this Oct 26, 2026
@JinDX

JinDX commented Oct 26, 2026

Copy link
Copy Markdown
Author

@mjwilson-google
Thanks for pointing this out! #288 covers this fix, so I've closed this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants