Skip to content

Feature/devcontainer setup - #15

Open
unilynx wants to merge 1 commit into
mainfrom
feature/devcontainer-setup
Open

unilynx wants to merge 1 commit into
mainfrom
feature/devcontainer-setup

Conversation

@unilynx

@unilynx unilynx commented Sep 25, 2026

Copy link
Copy Markdown
Member

@WebHare/reviewers point of discussion: can we still do some sort of smoke test (a full CI seems like too much) after wh builddocker/wh make install to somewhat test the final product? right now the only (implicidt) check is 'did not return an error code'

@unilynx
unilynx requested a review from a team September 25, 2026 12:31
Comment thread .github/workflows/devcontainer.yml Fixed
Comment thread .github/workflows/devcontainer.yml Fixed
@unilynx
unilynx marked this pull request as draft October 5, 2026 10:01
@unilynx
unilynx force-pushed the feature/devcontainer-setup branch from 411215a to 10ec48a Compare October 11, 2026 17:19
webharebot[bot]
webharebot Bot previously approved these changes Oct 11, 2026

@webharebot webharebot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto-Approved: PR author (@unilynx) is an internal organization/repository member.

webharebot[bot]
webharebot Bot previously approved these changes Oct 11, 2026

@webharebot webharebot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto-Approved: PR author (@unilynx) is an internal organization/repository member.

webharebot[bot]
webharebot Bot previously approved these changes Oct 11, 2026

@webharebot webharebot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto-Approved: PR author (@unilynx) is an internal organization/repository member.

@unilynx
unilynx marked this pull request as ready for review October 11, 2026 17:24
@unilynx
unilynx force-pushed the feature/devcontainer-setup branch from e2cb147 to 8cb1a11 Compare October 11, 2026 17:25

@webharebot webharebot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto-Approved: PR author (@unilynx) is an internal organization/repository member.

@unilynx
unilynx force-pushed the feature/devcontainer-setup branch from 8cb1a11 to e6f0ab7 Compare October 14, 2026 15:27
@unilynx

unilynx commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

@blexrob I suggest still commiting this, just on the schedule and not part of normal CI, as a smoke test that the promises made by the devcontainers (being table to run make install en builddocker) are failing

once a week is enough, and if it breaks we can look into whether it's actually affecting runkit and downstream escorws

@unilynx
unilynx requested a review from blexrob October 14, 2026 15:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants