Repository navigation
AST visitors - #254
Merged
Merged
AST visitors#254
Conversation
WerWolv
requested changes
Sep 9, 2026
WerWolv
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the a visitor framework for traversing the AST.
It consists of an abstract class (iface)
ASTVisitorwhich implementsvisitfor all the available AST node types.... +- the actual ASTNode... maybe we don't need this fallback... idk......... Also a pure virtual methodaccept(ASTVisitor&)for AST nodes. The visitor pattern, nothing fancy.I also added getters for nodes which didn't expose some valuable fields.
One visitor example is the iface for writing AST validators, called
ASTValidator. It implements all methods as empty, so you don't need to do that for all the children when you don't care about some nodes.The AST validators are combined in a pipeline, which is meant to replace the current validator.
This branch is created from the previous one, so it has the commits from the last PR. I just couldn't wait to share this code.
I don't want to commit more until we sort out the includes, namespaces or filesystem locations for my additions. Then I'll follow with the 2 validators and also a CLI command to generate GV files (this is an example for non-validating visitor).