Repository navigation
New validators - #257
Open
Nemoumbra wants to merge 3 commits into
Open
New validators#257Nemoumbra wants to merge 3 commits into
Nemoumbra wants to merge 3 commits into
Conversation
WerWolv
reviewed
Sep 13, 2026
| #include <pl/core/ast/ast_node_match_statement.hpp> | ||
| #include <pl/core/ast/ast_node_conditional_statement.hpp> | ||
|
|
||
| namespace pl::core { |
Owner
There was a problem hiding this comment.
From what I can tell, this only handles control flow statements in functions but not inside types, correct?
| } | ||
|
|
||
| void ScopeValidator::visit(ast::ASTNodeEnum &node) { | ||
| // TODO: enums are broken |
Owner
There was a problem hiding this comment.
Broken how? This definitely needs to be fixed before merge
Contributor
Author
There was a problem hiding this comment.
Broken "duplicate enum entries should be handled in the parser as we discussed in Discord".
Owner
|
Code wise this looks great! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to the 2nd PR: 2 validators for the pipeline. The old one has been removed.
Also enables the tests I added in the 1st PR... except for the duplicate enum test.
We already discussed this issue and how to resolve it, so it's not in the scope of this PR.
Let's see if it holds water.