Repository navigation
Fix REXML 3.4.4 nodeset warnings in fault handling - #362
Merged
Merged
Conversation
Closed
Contributor
Author
|
@adfoster-r7 thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #355, thanks to @adfoster-r7 for the diagnosis.
REXML 3.4.4 dropped nodeset support in
XPath.first, so passing thesoap_errorsarray warns on every fault response. Since a leading//is document-absolute in REXML anyway, searchingresponse_xmldirectly is exactly equivalent to the old nodeset behavior on all REXML versions.(Deliberately not the
find-based form from the issue:findreturns the Fault child element rather than the matched node, which would changeWinRMWSManFault's message andCode.)