Repository navigation
logger: Allow 1.5 - #367
Merged
Merged
Conversation
1.5 is the version of the vendored gem in Ruby 3.2. winrm doesn't use any 1.6 specific logic. By lowering the version to 1.5, we can use the bundled version in Ruby 3.2 and don't have to install additional gems. See https://stdgems.org/3.2.11/ for details.
sebastianrakel
approved these changes
Oct 12, 2026
Contributor
|
@bastelfreak thank you |
Contributor
Author
|
@pcai thanks for the quick merge! Any chance you can create a new release? |
Merged
pcai
added a commit
that referenced
this pull request
Oct 13, 2026
Cut 2.4.2 with the changes that landed since 2.4.1. - Replace erubi with the Ruby standard library ERB; the erubi runtime dependency is gone (#366) - Allow the `logger` dependency at version 1.5, so Ruby 3.2 users can use the bundled gem (#367) Bumps the version to 2.4.2 and records both changes in CHANGELOG.md.
Contributor
|
All set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.5 is the version of the vendored gem in Ruby 3.2. winrm doesn't use any 1.6 specific logic. By lowering the version to 1.5, we can use the bundled version in Ruby 3.2 and don't have to install additional gems.
See https://stdgems.org/3.2.11/ for details.
What kind of change is this?
allow loger 1.5 dependency
Did you add tests for your changes?
yes, works for me
Summary of changes
Other information