Skip to content

Replace pricing draft with a thin pricing API - #4

Merged
JimCollinson merged 2 commits into
mainfrom
feat/pricing-slim-v1
Sep 16, 2026
Merged

JimCollinson merged 2 commits into
mainfrom
feat/pricing-slim-v1

Conversation

@JimCollinson

@JimCollinson JimCollinson commented Sep 15, 2026

Copy link
Copy Markdown
Member

Current candidate (16 September): 498dea5698ce28c254e8774343f869855a530019. Initial external reviews returned Concerns; the bounded corrections now have green CI and await targeted Hermes re-review. The current reader checks required fields only; see the updated specification. No merge or activation approval is implied.

Summary

  • Serve one dated Inventory record through a bounded KV read and basic validation; no request-time collection, calculation or evidence replay.
  • Retain valid historical pricing without age-based withdrawal.
  • Share root and llms discovery descriptions while preserving existing supply formats, wallet accounting, caching, provider fallback and health behavior.
  • Add ordinary no-deploy tests and the pinned Proposed ADR governance baseline.

This replaces the approach in the earlier draft #3, which is left untouched as a reference.

Hermes review

Review this together with the Inventory PR #3 and website PR #11.

Current targeted Hermes handoff — fresh checkouts, repository setup, actual exercise, exact SHAs and command results. The handoff and Inventory repository require organisation access. Hermes review is pending; the local Fable review was not run and is explicitly replaced by this owner-selected route, not marked passed.

Evidence and boundaries

  • Branch CI at 93bd5e6: 67 tests, pinned Wrangler dry-run and ADR checker passed. New PR checks are separate.
  • Existing supply behavior is compared against the actual base Worker. Integrated adversarial and final Craft reviews passed; see the shared ledger.
  • Production configuration, deployment workflow and legacy files are unchanged. No pricing binding or data was provisioned.
  • Both ADRs remain Proposed. Keep draft pending Hermes and human decisions. No merge/deploy authorization: merging main triggers the existing deployment workflow, and the two public hostnames are the same Worker, not separate staging.

- Add a bounded Inventory pricing reader and shared root/llms discovery.
- Preserve supply and health with baseline parity tests and a dated public fixture.
- Add no-publish test CI, local checks, and pinned Proposed ADR governance.
- Preserve complete envelopes without gating on cosmetic or diagnostic metadata
- Update approved reader tests, Proposed ADR links and placeholder binding guidance
@JimCollinson

Copy link
Copy Markdown
Member Author

The approved thin-reader correction and documentation fixes are pushed at 498dea5698ce28c254e8774343f869855a530019; fresh tests, pinned dry-run bundle and ADR checks pass. Supply/health and production configuration are unchanged; the KV example is documentation only. Please review together with the Inventory/website corrections using the single targeted Hermes follow-up (organisation access required). Exact-head external approval remains pending. This stays draft: merging main deploys the Worker and is not performed by this update.

@JimCollinson

Copy link
Copy Markdown
Member Author

External approval and owner release authorization

Jim supplied Hermes APPROVE for exact head 498dea5698ce28c254e8774343f869855a530019, revalidated 16 September. Hermes reported 44 API tests, pinned dry-run bundle and direct security-relevant inspection. Two panel seats approved; the security seat timed out and was excluded, not counted as an approval. This comment records that external report; it is not an impersonated GitHub review.

Jim has now inspected the complete reviewed website preview and explicitly said he is happy to proceed with the agreed API -> Inventory -> website merges. Exact head and green CI rechecked. Normal merge controls will be used, without administrative override.

The API main merge triggers the existing Worker deployment. Pricing KV is not configured, so pricing remains unavailable as documented until separately authorized activation. No namespace, token, schedule activation or ADR-status change is authorized here. Existing supply behavior must pass deployment smoke checks before continuing.

@JimCollinson
JimCollinson marked this pull request as ready for review September 16, 2026 15:01
@JimCollinson
JimCollinson merged commit 60c64fd into main Sep 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant