Repository navigation
feat(keepawake): stop Keep Awake from draining a low battery - #14
Merged
Merged
Conversation
- Turn off Keep Awake at or below a cutoff while on battery - Refuse to turn it back on until charging or above the cutoff - Persist the cutoff, on by default at 20%, clamped to 5-50%
- Feed battery readings and the cutoff setting to Keep Awake - Add cutoff toggle and 5% stepper to Keep Awake settings - Disable the dashboard cup while the battery blocks it - Document the cutoff in the README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep Awake kept a MacBook awake on battery power until it ran flat. It now turns itself off when the battery reaches 20% while unplugged, and you can change that percentage.
Testing
swift testinPackages/BarometryKitpasses. New tests cover the cutoff turning Keep Awake off, blocking it from turning back on, being ignored while plugged in or without a battery, lifting when charging starts, and the new settings' defaults and persistence.