Repository navigation
feat(dashboard): show top apps with icons instead of cut-off process names - #15
Merged
Merged
Conversation
- Show process memory as whole MB or GB with one decimal - Limit process values to one line
- Sum each process's usage into the app macOS holds responsible - Name each app from its outermost bundle, or the executable name - Rename the top-process types and lists to apps - Update README and privacy wording for top-app lists
- Show each app's icon, or the generic executable icon outside an app - Cache icons since the lists redraw on every reading - Truncate app names at the end instead of the middle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top-process lists in the dashboard details were hard to use. Names like
com.apple.WebKit.WebContentandMicrosoft Edge Helper (Renderer)were cut off to the point of being unreadable. One app could fill most of the list: three of four rows were Safari tabs. Memory values like "1,019.5 MB" also wrapped onto two lines.The lists now rank apps, the way Activity Monitor's Energy tab does:
The responsible app comes from
responsibility_get_pid_responsible_for_pid, the same private macOS lookup Activity Monitor uses. Barometry loads it at runtime. If it's missing, each process counts as its own app, so the lists show one row per process again.Testing
swift testinPackages/BarometryKitpasses. New tests cover adding up an app's processes and naming the app from the outermost.appin its path.