Repository navigation
fix(settings): let menu bar modules and dashboard sections be dragged to reorder - #16
Merged
Merged
Conversation
- Replace onMove, which macOS ignores outside a List, with onDrag/onDrop so settings rows reorder as they're dragged - Apply to menu bar modules and dashboard sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Modules list in Menu Bar settings shows drag grips and says "Drag to rearrange them," but dragging did nothing. Dashboard → Sections had the same problem. The rows used SwiftUI's
onMove, which macOS only honors inside aList, and these rows live in a groupedForm.Rows now reorder with drag and drop and shift into place as you drag over them. Both panes share a small
reorderablemodifier. Menu bar modules still reorder only in the Combined layout, and the right-click Move Up/Down commands are unchanged.Testing