Repository navigation
fix(cpu): show Super cores on M5 Macs instead of calling every core Performance - #18
Merged
Merged
Conversation
- Add a Super core kind and class perflevels by hw.perflevelN.name - Map device tree cluster types E, M, P to perflevels by tier - Show Super cores in the dashboard core grid and summary rows - Cover M1-M4, base M5, M5 Pro/Max, and multi-die layouts in tests
- Report a frequency per core kind instead of fixed E and P fields - Read MCPU channels used by M5 Pro/Max Performance clusters - Find missing voltage-state tables through pmgr acc-clusters - Use the fastest active tier as the headline CPU clock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On M5 Macs, Barometry listed every core as a Performance core. Apple renamed the core tiers with M5: the fastest cores are now Super cores, and the M5 Pro and Max replace Efficiency cores with a new mid-tier called Performance. Barometry assumed the M1–M4 layout, so an M5 Max showed 18 Performance cores and its clock readings were mislabeled or missing.
Barometry now classifies cores by the tier names macOS reports (
hw.perflevelN.name) and matches them to the device tree's per-core cluster types, so each chip shows its real layout. The CPU details show a Super row and S-labeled cells in the core grid, and every tier gets its own clock speed, including the new M5 Pro/Max Performance clusters.Testing
swift testpasses, with new cases for the M1–M4, base M5, M5 Pro/Max, and multi-die layoutsxcodegen generateandxcodebuild, at each commit