Repository navigation
fix(palette): let the palette shadow fade out instead of cutting off - #33
Merged
Merged
Conversation
- Widen the panel margin so the shadow fades out before the edge - Derive the margin from the shadow radius and offset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In light mode, the command palette's drop shadow looked square. It stopped at a hard edge before it faded out.
The panel is a borderless window. It leaves a transparent margin around the glass so a SwiftUI shadow can follow the rounded corners. That margin was 32pt. The shadow uses a 16pt radius and an 8pt downward offset, so it reaches about 34pt past the glass on the sides and about 42pt below it. The window edge cut the shadow off while it was still visible.
The shadow's radius and offset now live in
PaletteMetrics, and the margin is calculated from them (3 * radius + offset, which is 56pt). Changing the shadow later can't bring the clipping back.Testing
ImageRenderer. With a 32pt margin the edge pixels were still visible. With 56pt they were fully transparent.