Repository navigation
fix(tabs): stop new connections from opening without a tab - #34
Merged
Merged
Conversation
- Disable closing the browser window while sessions are open - Prevent new sessions from starting without a tab - Restore closing once the last session closes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting to a machine sometimes started the session (the sidebar showed its badge) without opening a tab. The only way out was to restart the app.
The machine-details view is the app's main window. When sessions are open it appears as an extra tab, and its SwiftUI view is what turns new sessions into native tabs. Closing that tab (its close button, ⇧⌘W or the red window button) destroyed the window. From then on, every new session started without a tab until the app was restarted. The SSH host-key prompt that appeared at the same time was a coincidence.
The machine-details window now can't be closed while any session is open. Its close button is disabled and ⇧⌘W does nothing. You can still leave it by clicking another tab. Once the last session closes, the window can be closed again as before.
Testing