Repository navigation
fix: stop losing saves silently and keep usernames out of support bundles - #36
Merged
Merged
Conversation
- Replace the home directory with ~ in logged Ghostty diagnostics - Keep full messages in Terminal settings
- Write secrets before the library change and restore them on failure - Keep references to secrets the Keychain refuses to delete - Report Keychain removal failures instead of ignoring them - Add tests for failed writes, rejected saves and refused removals
- Alert when Always Trust cannot be stored; still connect once - Add a test for a trust store that refuses writes
- Describe Sparkle update checks against GitHub releases - Describe Azure Virtual Desktop sign-in and feed requests - List persisted Microsoft sign-in cookies and how to remove them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review turned up a few places where Constellation could say it had done something it hadn't, plus a privacy promise it wasn't keeping:
/Users/<name>/.config/ghostty/config.PRIVACY.mdsaid there were no update checks and didn't mention Azure Virtual Desktop sign-in or the Microsoft sign-in cookies the app keeps.What changes:
~. The Terminal settings screen still shows the full message.~/Library/WebKitand~/Library/HTTPStorages. The "Removing your data" section lists those folders too.Testing