Skip to content

fix: stop losing saves silently and keep usernames out of support bundles - #36

Merged
WolffTech merged 5 commits into
mainfrom
t3code/fix-privacy-and-persistence-issues
Oct 1, 2026
Merged

WolffTech merged 5 commits into
mainfrom
t3code/fix-privacy-and-persistence-issues

Conversation

@WolffTech

Copy link
Copy Markdown
Owner

A review turned up a few places where Constellation could say it had done something it hadn't, plus a privacy promise it wasn't keeping:

  • Support bundles promise no account names, but they copy the app's logs, and Ghostty config diagnostics were logged publicly with full file paths such as /Users/<name>/.config/ghostty/config.
  • Saving a machine committed the library change before writing its passwords. If the Keychain write failed, the profile was saved without its password. Deleting unused credentials ignored Keychain errors, so the password stayed in the Keychain while the app dropped its record of it.
  • "Always Trust" on an RDP certificate and the workspace save at quit both ignored storage errors, so the app looked like it had remembered something it hadn't.
  • PRIVACY.md said there were no update checks and didn't mention Azure Virtual Desktop sign-in or the Microsoft sign-in cookies the app keeps.

What changes:

  • Logs: logged Ghostty diagnostics show the home folder as ~. The Terminal settings screen still shows the full message.
  • Machine saves: passwords are written before the library change. If either step fails, the Keychain is put back as it was, so a profile is never saved without its password. If putting it back also fails, the error says so.
  • Credential deletion: the Keychain item is deleted first, and the library record goes only once it's gone. If the Keychain refuses, the user sees an error and the credential stays listed as unused, so it's offered for removal again. This also applies when an edit drops a password.
  • Always Trust: if the decision can't be saved, an alert says so. The connection still goes ahead once, and the user will be asked again next time.
  • Quit: if the open tabs can't be saved, the user picks between "Quit Anyway" and "Cancel". Sessions are already disconnected by then, so Cancel keeps the tabs but not the connections.
  • Privacy policy: now covers Sparkle update checks against GitHub releases, Azure Virtual Desktop sign-in and desktop-list traffic to Microsoft, and the sign-in cookies stored under ~/Library/WebKit and ~/Library/HTTPStorages. The "Removing your data" section lists those folders too.

Testing

  • The full scheme passes, including every package suite.
  • New tests cover:
    • a failed Keychain write that leaves the library untouched
    • a rejected library change that restores the old password and removes a new one
    • refused Keychain removal, both for unused credentials and for a password dropped in the editor
    • an "Always Trust" decision the trust store refuses
    • home-folder redaction in logged diagnostics
  • Not tested in the app: the new alerts (trust save failure, quit without saved tabs). Triggering them needs a failing database.

- Replace the home directory with ~ in logged Ghostty diagnostics
- Keep full messages in Terminal settings
- Write secrets before the library change and restore them on failure
- Keep references to secrets the Keychain refuses to delete
- Report Keychain removal failures instead of ignoring them
- Add tests for failed writes, rejected saves and refused removals
- Alert when Always Trust cannot be stored; still connect once
- Add a test for a trust store that refuses writes
- Describe Sparkle update checks against GitHub releases
- Describe Azure Virtual Desktop sign-in and feed requests
- List persisted Microsoft sign-in cookies and how to remove them
@WolffTech
WolffTech merged commit bcbaab3 into main Oct 1, 2026
2 checks passed
@WolffTech
WolffTech deleted the t3code/fix-privacy-and-persistence-issues branch November 10, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant