Repository navigation
build(deps): move libghostty to the Ghostty v1.4.0 release - #38
Merged
Merged
Conversation
- Pin Vendor/ghostty to the v1.4.0 release tag - Build with Zig 0.17.0, which v1.4.0 requires - Update license manifest, notices and SECURITY.md versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libghostty 1.0 just shipped, which prompted a look at our terminal dependency. That 1.0 is libghostty-vt, the standalone VT library with a stable C ABI. We don't use it: SSH tabs embed Ghostty's surface API through
GhosttyKit, which the 1.0 promise doesn't cover. Our pin was an untaggedmaincommit from September (de53b335, v1.3.1+2689), 556 commits behind Ghostty's latest release.This moves
Vendor/ghosttyto the v1.4.0 release tag, so we build the same surface API that a shipped Ghostty.app uses. v1.4.0 requires Zig 0.17.0, so the pinned Zig inScripts/build-libghostty.shmoves from 0.16.0 to 0.17.0, with the checksum from ziglang.org. Theghostty.hchanges between the two commits are additive only: a new resize-window action andghostty_surface_paste_text. The license manifest, third-party notices andSECURITY.mdnow show the new version.Proof: I rebuilt GhosttyKit from v1.4.0 and ran the full
xcodebuild testsuite, which passed, including the real-surface terminal suites. I also launched the app, opened a local terminal tab, and ran a command with ANSI colors; it rendered correctly and accepted input.