Conversation
Member
|
Rebase,@yuhan6665 你看看 |
JkLondon
force-pushed
the
jklondon/reality-x25519
branch
from
September 21, 2026 00:03
344f62e to
315178e
Compare
JkLondon
marked this pull request as ready for review
September 21, 2026 00:05
Member
|
顺便试试能不能 linkname #37 (comment) ,都放这个 PR 里吧 |
Member
跟原版比似乎少了一个copy 不知道会不会有问题? |
Member
|
|
Draft
Member
|
个人感觉无所谓 在非瓶颈的路径上加缓存快点是快点但是终归是反模式 也就让握手快了 0.029 ms |
JkLondon
force-pushed
the
jklondon/reality-x25519
branch
2 times, most recently
from
September 21, 2026 07:43
9bcc460 to
160630b
Compare
`Config.PrivateKey` is now `*ecdh.PrivateKey`, parsed once by the caller. This avoids deriving the same static public key on every authentication attempt. Auth DH: 58.08 → 29.13 µs, 7 → 3 allocs/op (Go 1.27.0, darwin/arm64, Apple M3 Max; 10 runs). Microbenchmark only. Checked locally: race detector, amd64 correctness and FIPS enforcement.
JkLondon
force-pushed
the
jklondon/reality-x25519
branch
from
September 21, 2026 08:00
160630b to
920c977
Compare
Author
|
Thanks for the discussion) Sadly, I don't know Chinese but as I understand from the translation :
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.PrivateKeyis now*ecdh.PrivateKey, parsed once by the caller. This avoids deriving the same static public key on every authentication attempt.Auth DH: 58.08 → 29.13 µs, 7 → 3 allocs/op (Go 1.27.0, darwin/arm64, Apple M3 Max; 10 runs). Microbenchmark only.
Checked locally: race detector, amd64 correctness and FIPS enforcement.