Correct the hand edits on insight #3 - #328
Merged
Merged
Conversation
Four things from the direct edit, and the wrapping they came with: - "thant can be" -> "that can be". - "so lets check" -> "so let's look at what that makes possible", and the hyphen before it is the em dash the rest of the page uses. - "somebody wrote in 2000s" -> "in the 2000s". - "This could be called programming model agnostic. RAP is a programming model. A MODIFY is not" lost the connective between the label and the argument against it, so the paragraph asserted the term and then contradicted it with nothing in between. "- except RAP is a programming model, and a MODIFY is not" keeps the softer "could be called" and puts the logic back in one word. Three edited paragraphs had been rewritten as single long lines; they are wrapped back to the column the rest of the file is set in. Left as written: the closing "Give abap2UI5 a try" and its dinosaurs. A call to action is what #1 and #2 close on too, and the three decades of ABAP above it are what the joke is about. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0182AiPodwfGRKPNZG9D5epe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the direct edit in
e02918d. Four corrections and the line wrapping that came with it.Corrections
thant can bethat can becall - so lets check the possibilities we get next:call — so let's look at what that makes possible:somebody wrote in 2000ssomebody wrote in the 2000sThe only one that is not mechanical: "This gets called programming model agnostic, and that phrase is too small for it" became "This could be called programming model agnostic." — which dropped the bridge between the label and the argument against it, so the paragraph asserted the term and then contradicted it with nothing in between. The softer "could be called" stays; one word puts the logic back:
Wrapping
Three edited paragraphs came back as single long lines (the first at 140 characters). Invisible in the editor, but in a diff the whole paragraph is then one changed line, so every later correction to it reads as a rewrite. Wrapped back to the column the rest of the file is set in.
Left as written
The closing
Give abap2UI5 a try. 🦖🦕🦣. #1 and #2 both close on a call to action, #1 already carries an emoji in its prose, and the three decades of ABAP above it are what the joke is about.One thing for the author to decide rather than for this PR: the call to action now stands after the closing line
One class, no programming model, and no opinion about what is behind the screen., which was built as the last word because it echoes the title. #2 has it the other way round — call to action first, then the kicker. The order is left exactly as edited.Gates
test(251),check:conventions,check:playground,check:examples,check:api-names,check:api-referenceanddocs:buildpass locally.🤖 Generated with Claude Code
https://claude.ai/code/session_0182AiPodwfGRKPNZG9D5epe
Generated by Claude Code