Repository navigation
Stage case members under the names a run gives them - #445
Merged
Merged
Conversation
FileSeekerZip replaces the characters Windows cannot hold in a file name on every platform. The test harness used ZipFile.extract, which replaces fewer of them and only on Windows, so a case recorded on macOS or Linux saw staged names no run produces. The harness now stages each member through the seeker's own extract. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test harness now stages each case member through the seeker's own extract, so a test sees the staged names a real run gives.
:and'on every platform.ZipFile.extractreplaced fewer, and only on Windows.test_harness_stages_like_the_seeker.pyfails on main on macOS and on a Windows 11 VM, and runs in the Windows smoke job.:becoming_in one source-path column.🤖 Generated with Claude Code