test(alerts): add unit tests for AlertDeriver.get_threshold/get_threshold_async - #314
Open
acailic wants to merge 1 commit into
Open
test(alerts): add unit tests for AlertDeriver.get_threshold/get_threshold_async#314acailic wants to merge 1 commit into
acailic wants to merge 1 commit into
Conversation
…hold_async Covers the sync/async policy-getter paths on collector/alerts/base.py (lines 44-50, 68-74), including the documented sync-context limitation where get_threshold returns the default immediately for an async policy_getter instead of awaiting it. Fixes #311 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/alerts/test_alert_deriver_base.pycoveringAlertDeriver.get_thresholdandget_threshold_asynconcollector/alerts/base.py(previously 0% coverage on lines 44-50, 68-74)get_thresholdreturns the default immediately instead of awaiting)Fixes #311
Test plan
ruff check .— all checks passedpython3 -m pytest -q tests/alerts/test_alert_deriver_base.py— 9 passed, no warningspython3 -m pytest -q(full suite) — 3162 passed, 19 skipped, 15 deselected🤖 Generated with Amplifier