Repository navigation
Conversation
|
Hello @tagolog 👋 Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.
Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description. Frequently asked questionsHow do I add reviewers? This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically. You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using What if there are no comments? If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers. Are any special GitHub settings required to contribute to LLVM? We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details. If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse. Thank you, |
isPreprocessedModuleFile() scans the whole source line by line, looking for "__preprocessed_module" or "__preprocessed_import" directives. This scan is pretty expensive. Add fast path by checking for the presence of "__preprocessed_" string. On `swiftlang/llvm-project`, a cache hit through `clang-cache` with its default inline dependency scan drops - from 201.4 to 189.8 ms (-5.7%) on Windows - from 107.7 to 100.3 ms (-6.9%) on Linux
e3f89de to
04760aa
Compare
|
Implemented in PR 239449 |
isPreprocessedModuleFile() scans the whole source line by line,
looking for "__preprocessed_module" or "__preprocessed_import"
directives. This scan is pretty expensive.
Checking for the presence of
__preprocessed_string in the sourcespeeds up the scan. On
swiftlang/llvm-project, a cache hit throughclang-cachewith its default inline dependency scan drops