Repository navigation
Conversation
4 tasks
HachemJ
force-pushed
the
AddCandidateIdentifierTypeConfiguration
branch
2 times, most recently
from
October 23, 2026 20:31
6426a4a to
e879f6a
Compare
HachemJ
force-pushed
the
AddCandidateIdentifierTypeConfiguration
branch
2 times, most recently
from
October 27, 2026 15:08
db09fa2 to
63110b2
Compare
HachemJ
force-pushed
the
AddCandidateIdentifierTypeConfiguration
branch
from
October 27, 2026 15:32
63110b2 to
f9952a1
Compare
HachemJ
force-pushed
the
AddCandidateIdentifierTypeConfiguration
branch
from
October 27, 2026 16:41
ad829fd to
90462da
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR introduces a Configuration interface for managing candidate identifier types, building on the database structure and backend functionality introduced in the preceding PRs #11209, #11212 and #11253.
Candidate identifier types define how identifiers such as PSCIDs or external IDs are configured and associated with projects. The new interface allows administrators to create and edit these types through the Configuration module, including their name, format, required and uniqueness settings, automatic generation, support for multiple values, and associated projects.
Existing identifier types are displayed in separate tabs alongside an option to create a new type. The interface follows the conventions of the existing LORIS Configuration pages, with field descriptions, save and reset functionality, and validation for required fields and duplicate names.
Testing instructions (if applicable)
Run
make testdatato initialize the database, or apply the2026-09-22-add_candidate_identifiers_tables.sqldatabase patch to an existing database.Log in with a user who has the
configpermission.Navigate to Admin --> Configuration --> Candidate Identifier Types.
Verify that existing identifier types, such as PSCID, appear in separate tabs with their configured properties and project associations.
Select New Identifier Type, enter a name and format, configure the checkboxes and associated projects, and click Save.
Verify that a success message appears and the new identifier type is displayed after reloading.
Edit an existing identifier type, save the changes, and verify that the updated values persist after reloading.
Attempt to create an identifier type with an existing name and verify that a validation error appears without saving any changes.
Attempt to save an identifier type with an empty name or format and verify that validation prevents saving.
Verify that field tooltips display correctly and that Reset restores unsaved changes.