Skip to content

review-validator: make asynchronous timing wrappers shell-portable #89

Closed

Description

@acgetchell

Summary

Make review-validator's asynchronous timing guidance safe across supported executor shells.

Current State

review-validator/references/execution-timing.md recommends the declared shell's time -p. During a repository review on macOS with zsh, a fresh validator followed that guidance and produced zsh:1: command not found: -p; just ci never started. The runtime correctly retained a blocked launch, but recovery then required proof compilation and a quiescent graph.

Proposed Changes

Provide a runtime-owned, shell-independent execution/timing helper, or explicit tested wrappers for each supported shell. Document how to retain the actual subprocess exit status and monotonic elapsed time across asynchronous polling. Reject unsupported timing wrappers before launching a validation unit.

Benefits

Avoid failed validation launches and graph recovery overhead caused by the skill's own example while retaining reliable execution-side timing evidence.

Implementation Notes

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions